Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect output to /dev/null #2880

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Redirect output to /dev/null #2880

merged 3 commits into from
Jul 2, 2023

Conversation

alexiri
Copy link
Contributor

@alexiri alexiri commented Jul 2, 2023

Fixes #2877, #2878 and #2879.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

willmcgugan
willmcgugan reviewed Jul 2, 2023
View reviewed changes
src/textual/app.py Outdated Show resolved Hide resolved
@alexiri alexiri force-pushed the alexiri-patch-1 branch from 62b106d to b283670 Compare July 2, 2023 15:20
@alexiri alexiri force-pushed the alexiri-patch-1 branch from b283670 to e8eeac8 Compare July 2, 2023 15:28
willmcgugan
willmcgugan requested changes Jul 2, 2023
View reviewed changes
src/textual/app.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@willmcgugan willmcgugan merged commit 339505e into Textualize:main Jul 2, 2023
@alexiri alexiri mentioned this pull request Jul 2, 2023
Closed
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Textual interferes with other libraries' use of logging
2 participants
@alexiri @willmcgugan