Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mount order #2702

Merged
merged 5 commits into from
May 31, 2023
Merged

mount order #2702

merged 5 commits into from
May 31, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented May 31, 2023 •
edited
Loading

  • Fix an issue with mount order
  • Also added message_hook to App.run_test to inspect all messages going through the app

@davep davep linked an issue May 31, 2023 that may be closed by this pull request
Setting Select.value in on_mount for a Select in a container raises an exception #2662
Closed
@davep
Copy link
Contributor

davep commented May 31, 2023

Note to add that this fixes the underlying cause of #2662

@willmcgugan willmcgugan merged commit 0849e6f into main May 31, 2023
@willmcgugan willmcgugan deleted the mount-order branch May 31, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting Select.value in on_mount for a Select in a container raises an exception
2 participants
@willmcgugan @davep