Exit debug #2554
Merged
Exit debug #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
approved these changes
May 14, 2023
Comment on lines
+1641
to
+1647
| elif self._exit_renderables: | ||
| self.error_console.print(self._exit_renderables[0]) | ||
| if error_count > 1: | ||
| self.error_console.print( | ||
| f"\n[b]NOTE:[/b] 1 of {error_count} errors show. Run with [b]--dev[/] to see all errors.", | ||
| markup=True, | ||
| ) |
There was a problem hiding this comment.
This makes sense. At the same time, the error(s) may show up unexpectedly and the user may not be able to reproduce them. Would it make even more sense to write the remaining errors to a log?
There was a problem hiding this comment.
If logging is enabled, these will still go to the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fatal errors will cause a cascade of additional errors. Generally the first one is most relevant.
Fixes #2480