Add add_options to OptionList
#2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps a hangover from a previous take on this, or just a copy/paste-o. Either way I just noticed this so thought I'd roll it in here.
In doing so, pretty much make the add_option code into the add_options code, and then just have add_option call add_options. See Textualize#2507.
Extending a list with an empty list is petty much a no-op so don't bother to faff around testing for what Python will be testing for anyway.
This tests the three main ways of making an option list, and ensures they all turn out the same.
willmcgugan
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
add_option, just with moreOption.