Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable scrolling faq #2477

Merged
merged 6 commits into from
May 4, 2023
Merged

Datatable scrolling faq #2477

merged 6 commits into from
May 4, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

Write more concisely.

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 4, 2023
@rodrigogiraoserrao rodrigogiraoserrao added documentation Improvements or additions to documentation enhancement New feature or request labels May 4, 2023
willmcgugan
willmcgugan requested changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's either lose the example entirely, or have a have an example simply shows a correctly sizing table.

The FAQ should contain fairly concise answers. It's not intended to be didactic.

questions/datatable-doesnt-scroll.question.md Outdated Show resolved Hide resolved
rodrigogiraoserrao and others added 2 commits May 4, 2023 11:17
@rodrigogiraoserrao @willmcgugan
Update questions/datatable-doesnt-scroll.question.md
ecf2183 
Co-authored-by: Will McGugan <willmcgugan@gmail.com>
@rodrigogiraoserrao
Remove example.
b100ed0
willmcgugan
willmcgugan reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably still want to recommend setting height 100% as that is a quick fix that would work for most use cases.

willmcgugan
willmcgugan approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it.

@rodrigogiraoserrao rodrigogiraoserrao merged commit cbd68b2 into main May 4, 2023
@rodrigogiraoserrao rodrigogiraoserrao deleted the datatable-scrolling-faq branch May 4, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigogiraoserrao @willmcgugan