Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out the primary Markdown bullet for one that works everywhere #1997

Merged
merged 2 commits into from
Mar 9, 2023
+134 −133
Merged

Swap out the primary Markdown bullet for one that works everywhere #1997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f854980
Swap out the primary Markdown bullet for one that works everywhere
davep Mar 9, 2023
2506a02
Refresh the snapshot tests
davep Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Updated styling to make it clear DataTable grows horizontally https://github.com/Textualize/textual/pull/1946
- Changed the `Checkbox` character due to issues with Windows Terminal and Windows 10 https://github.com/Textualize/textual/issues/1934
- Changed the `RadioButton` character due to issues with Windows Terminal and Windows 10 and 11 https://github.com/Textualize/textual/issues/1934
- Changed the `Markdown` initial bullet character due to issues with Windows Terminal and Windows 10 and 11 https://github.com/Textualize/textual/issues/1982

### Added

Expand Down
4 changes: 2 additions & 2 deletions src/textual/widgets/_markdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ class MarkdownBullet(Widget):
}
"""

symbol = reactive("●​")
symbol = reactive("\u25CF")
"""The symbol for the bullet."""

def render(self) -> Text:
Expand Down Expand Up @@ -500,7 +500,7 @@ class Markdown(Widget):
"""
COMPONENT_CLASSES = {"em", "strong", "s", "code_inline"}

BULLETS = ["⏺ ", "▪ ", "‣ ", "• ", "⭑ "]
BULLETS = ["\u25CF ", "▪ ", "‣ ", "• ", "⭑ "]

def __init__(
self,
Expand Down
Loading