Generate MouseUp events #1968
Merged
Generate MouseUp events #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
force-pushed
the
generate-mouseup-events
branch
from
ea5c6df to
5326ac9
Compare
willmcgugan
requested changes
Mar 7, 2023
src/textual/driver.py
Outdated
| y=event.y, | ||
| delta_x=event.delta_x, | ||
| delta_y=event.delta_y, | ||
| button=0, |
There was a problem hiding this comment.
I don't think that MouseUp.button should be 0 here. It should be the index of the button that was down in the corresponding MouseDown event.
@rodrigogiraoserrao Not speaking for Darren, of course, but as I look at the changes they're in the core driver, not any platform-specific driver. The only change I see to the Linux driver is to remove an unused import. |
|
Yeah, that looks to be the case. Could use a test on Windows just to be sure. |
willmcgugan
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.