Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DataTable race-condition crash #1962

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Mar 7, 2023

I think this fixes a crash reported #1955 in the DataTable. I wasn't able to reproduce the issue locally, so will wait to hear back on whether this fixes the issue.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns linked an issue Mar 7, 2023 that may be closed by this pull request
@pkazmier
Copy link

pkazmier commented Mar 7, 2023

The description above refers to itself. The issue this PR addresses was #1955.

@darrenburns darrenburns marked this pull request as ready for review March 7, 2023 12:52
@darrenburns darrenburns requested a review from willmcgugan March 7, 2023 12:52
@willmcgugan willmcgugan merged commit 1b06e50 into main Mar 7, 2023
@willmcgugan willmcgugan deleted the datatable-scroll-crash-fix branch March 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception when scrolling in DataTable
3 participants