Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable - Message emitted when header selected #1788

Merged
merged 10 commits into from
Feb 14, 2023
Merged

DataTable - Message emitted when header selected #1788

merged 10 commits into from
Feb 14, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 14, 2023 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns changed the base branch from main to datatable-private-data February 14, 2023 14:06
@darrenburns darrenburns marked this pull request as ready for review February 14, 2023 15:37
willmcgugan
willmcgugan approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc format request

src/textual/widgets/_data_table.py Outdated Show resolved Hide resolved
Base automatically changed from datatable-private-data to main February 14, 2023 16:37
@willmcgugan willmcgugan merged commit df1edb0 into main Feb 14, 2023
@willmcgugan willmcgugan deleted the datatable-select-headers branch February 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep Awaiting requested review from davep

@willmcgugan willmcgugan Awaiting requested review from willmcgugan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan