Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert retrofitting of example code in an old blog post #1741

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

davep
Copy link
Contributor

@davep davep commented Feb 8, 2023

Makes sense to update all the docs to reflect the work done in #1738 but I feel it doesn't quite make sense to retrofit this into an old blog post -- especially if the code it is referring to was like that at the time and likely still will be for a wee while after this gets republished.

Makes sense to update all the docs to reflect the work done in Textualize#1738 but I
feel it doesn't quite make sense to retrofit this into an old blog post --
especially if the code it is referring to was like that at the time and
likely still will be for a wee while after this gets republished.
@rodrigogiraoserrao
Copy link
Contributor

Apologies! I thought it made sense to do the change but if the blog post refers explicitly the textual version it was written for, I think your reversal makes sense.

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to keep a historical record in the blog.

@willmcgugan
Copy link
Collaborator

In the unlikely event that confuses people, I suggest we add some kind of admonition. Like "This has changed since the this post was published".

@willmcgugan willmcgugan merged commit d67510e into Textualize:main Feb 8, 2023
@davep
Copy link
Contributor Author

davep commented Feb 8, 2023

Apologies! I thought it made sense to do the change but if the blog post refers explicitly the textual version it was written for, I think your reversal makes sense.

Ahh, no apologies needed; it's an either/or call there I'd say. Your call on it made perfect sense. :-)

@davep davep deleted the revert-old-blog-post branch February 8, 2023 13:49
@davep
Copy link
Contributor Author

davep commented Feb 8, 2023

In the unlikely event that confuses people, I suggest we add some kind of admonition. Like "This has changed since the this post was published".

I like this. I'll likely do that once it's all settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants