Support easier widget "support classes" importing #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
approved these changes
Jan 23, 2023
willmcgugan
requested changes
Jan 23, 2023
Yup, happy to. Was holding that for a followup PR but if we're happy for the breaking change now that's my preference too. :-) |
This encourages importing it from `textual.widgets.tree` instead, keeping it in line with the other changes made for Textualize#1637. Note this is a breaking change.
This aims to make it clear that a small but significant breaking change has taken place. See Textualize#1637.
|
|
rodrigogiraoserrao
approved these changes
Jan 25, 2023
oleksis
added a commit
to oleksis/jtree
that referenced
this pull request
Aug 24, 2023
…ets; it is now available via from textual.widgets.tree import TreeNode. Textualize/textual#1637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggested solution for the requirement detailed in #1589. Quite simply, for those widgets that have non-widget support classes that the using-developer needs access to, have a parallel non-under-prefixed version of the code that imports and "reexports" the support classes.
As such, all this PR does is implement this approach for the widgets that seen to need it. The only one that required it at the moment was
DataTable, so thatColumnandRowcan be seen by the calling code.TreeNodealready had an approach to this but for the sake of completeness I've added parallel support for this newer convention.We may want to think about deprecating
widgets.TreeNode.