Add Tree.NodeHighlighted message
#1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm about to work on Textualize#1400 and it seems like a good idea to put some tests in place first to ensure nothing gets disturbed.
All three do the same thing, so we may as well give them a common base; especially given that we're about to go and add yet another message that'll do the same thing again but only (because we need it to) differ in name.
This is sort of different from selected. Selected is when someone mashes the enter button or clicks on a node. Highlighted is when the cursor moves into a new node. See Textualize#1400.
willmcgugan
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Tree.NodeHighlightedmessage, which differs fromTree.NodeSelectedin that the latter is emitted if the user clicks on a node, or hitsEnteron a node. The new message allows other widgets to react to the user simply cursoring through a collection of nodes.In doing this I've also reduced some of the duplication of effort when it comes to declaring
Treenode messages. I've also added some minimal unit tests forTreemessages.