-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public access (both get and set) to the label
of a TreeNode
#1487
Merged
+33
−3
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a1e63a1
Process the label on construction of a TreeNode
davep b8a3296
Add public access to a TreeNode's label
davep d39c59c
Move the TreeNode label tests into a better-named file
davep 18eae61
Remove unnecessary return from label.setter
davep b8727a8
Merge branch 'main' into tree-node-label-prop
davep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
from textual.widgets import Tree, TreeNode | ||
from rich.text import Text | ||
|
||
def test_tree_node_label() -> None: | ||
"""It should be possible to modify a TreeNode's label.""" | ||
node = TreeNode(Tree[None]("Xenomorph Lifecycle"), None, 0, "Facehugger") | ||
assert node.label == Text("Facehugger") | ||
node.label = "Chestbuster" | ||
assert node.label == Text("Chestbuster") | ||
|
||
def test_tree_node_label_via_tree() -> None: | ||
"""It should be possible to modify a TreeNode's label when created via a Tree.""" | ||
tree = Tree[None]("Xenomorph Lifecycle") | ||
node = tree.root.add("Facehugger") | ||
assert node.label == Text("Facehugger") | ||
node.label = "Chestbuster" | ||
assert node.label == Text("Chestbuster") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, what does it mean for the setter to return the new value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, come to think of it, in Python, nothing useful at all. Hangover from elsewhere (languages where assignments are also expressions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think C++ need that to chain assignments, like
foo = bar = obj.egg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto Clipper with the likes of Class(y), for those of a particular vintage (if I'm recalling correctly).