Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scrollbar rules from being ignored #1480

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Prevent scrollbar rules from being ignored #1480

merged 5 commits into from
Jan 6, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • [x] Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review January 4, 2023 14:52
@rodrigogiraoserrao rodrigogiraoserrao linked an issue Jan 4, 2023 that may be closed by this pull request
@willmcgugan
Copy link
Collaborator

Looks like the scrollbars have a rather sickly yellow color. I'm guessing because colors that were previously ignored are now updated?

You might need to change the defaults, to restore the original look.

Screenshot 2023-01-05 at 11 48 34

@rodrigogiraoserrao
Copy link
Contributor Author

@willmcgugan I only get that “sicklish” tone when scrollbars are being hovered and I thought that was the default styling for scrollbar-color-hover (which was being ignored).

Here is a screenshot: on the left, I have my mouse over the scrollbar (which also means that I do not have my mouse over the scrollbar on the right).

Screenshot at Jan 05 12-04-06

What color would you prefer, instead, for scrollbar-color-hover?

@willmcgugan
Copy link
Collaborator

Same color as before this update, which I believe didn't change the scrollbar thumb at all...

@rodrigogiraoserrao
Copy link
Contributor Author

Yes, before this update the scrollbar thumb wasn't updated when the scrollbar was hovered.

Upon hovering a scrollbar, do we want the default scrollbar-color-hover to match scrollbar-color or do we want it to be explicitly that specific shade of blue?

@willmcgugan
Copy link
Collaborator

Set it to the same shade should be fine. It still allows custom CSS to override it if desired.

@willmcgugan
Copy link
Collaborator

Looks good!

@willmcgugan willmcgugan merged commit 85afdba into main Jan 6, 2023
@willmcgugan willmcgugan deleted the fix-1479 branch January 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some scrollbar color styles have no effect
2 participants