Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queries/walk_children no longer includes self in results by default #1416

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Queries/walk_children no longer includes self in results by default #1416

merged 8 commits into from
Dec 21, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Dec 20, 2022 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns marked this pull request as ready for review December 21, 2022 11:46
@darrenburns darrenburns changed the title Add test for universal selector Queries/walk_children no longer includes self in results by default Dec 21, 2022
@willmcgugan willmcgugan merged commit a4aa30e into main Dec 21, 2022
@willmcgugan willmcgugan deleted the query-star-exclude-self branch December 21, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan