Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure watcher isn't called on first_set when init is False and value doesn't change #1367

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Ensure watcher isn't called on first_set when init is False and value doesn't change #1367

merged 3 commits into from
Dec 20, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Dec 15, 2022 •
edited
Loading

The "don't call a watcher when the value doesn't change" was not applied on the first set of a reactive attribute.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns changed the base branch from main to validator-first-set December 15, 2022 11:01
@darrenburns darrenburns marked this pull request as ready for review December 15, 2022 11:10
Base automatically changed from validator-first-set to main December 16, 2022 20:11
@darrenburns darrenburns merged commit af8af1b into main Dec 20, 2022
@darrenburns darrenburns deleted the validator-first-set-watch-called-incorrectly branch December 20, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan