Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible default key displays + allow users to override key displays at the App level #1213

Merged
merged 7 commits into from
Nov 18, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Nov 17, 2022

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

Example output from snapshot test in which user-land app overrides some stuff, and question mark comes from Textual defaults.

image

@darrenburns darrenburns changed the title Get rid of string split key display Sensible default key displays + allow users to override key displays at the App level Nov 17, 2022
@darrenburns darrenburns marked this pull request as ready for review November 17, 2022 19:18
@aaronst
Copy link
Contributor

aaronst commented Nov 18, 2022

Nice!

@willmcgugan
Copy link
Collaborator

Looks good. Is ^q a fairly standard convention then?

@davep
Copy link
Contributor

davep commented Nov 18, 2022

Looks good. Is ^q a fairly standard convention then?

(Chiming in from the older days...) I'd absolutely read ^q as "control Q", it's been a convention as long as I've known.

@darrenburns
Copy link
Member Author

Note that this PR will not make the ^ appear in the footer - that's just what I done in my test of the user overrides. Textual will still show CTRL+Q.

@darrenburns darrenburns merged commit 36664ef into main Nov 18, 2022
@darrenburns darrenburns deleted the key-display-improvement branch November 18, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants