Support callables in App.SCREENS #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
changed the title
davep
approved these changes
Nov 16, 2022
willmcgugan
reviewed
Nov 16, 2022
src/textual/app.py
Outdated
| @@ -1532,14 +1536,14 @@ async def _close_all(self) -> None: | |||
|
|
|||
| # Close all screens on the stack | |||
| for screen in self._screen_stack: | |||
| if screen._running: | |||
| if isinstance(screen, Screen) and screen._running: | |||
There was a problem hiding this comment.
Are we going to have something on the Screen stack that is not a screen?
There was a problem hiding this comment.
No, good catch. Have removed this isinstance check
willmcgugan
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to pass callables rather than Screen instances.