Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List view #1143
List view #1143
Changes from 33 commits
9cd6bda
93c7bf3
f6111e7
9f46df4
bab7889
8c9baaf
46bc494
d027adf
58b43ab
ed06e28
ab5d9bd
17dc927
6042346
fb9502f
5bc1606
58cbf3a
d665a6e
44cbce1
a131ac5
9572cbd
c1590fd
8b7670e
cc0a5e3
5ac3afd
a6c350b
b5a1a17
cbbfcb9
eafb9ec
b21eb06
afafc05
c57f6b9
be31894
4e0c77e
1317d19
eb8c078
01cbd7b
853d056
4834807
422f9be
0698bc2
f0c4023
29f4887
cebeafb
24a182c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line that ultimately resulted in those weird
NoScreen
errors. Because ListView has a__len__
, the condition was evaluating as False and terminating the search for the Screen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a
>
here? For the (hopefully rare) scenario of nested ListViews