Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Checkbox to Switch #1746

Closed
davep opened this issue Feb 9, 2023 · 1 comment · Fixed by #1751
Closed

Rename Checkbox to Switch #1746

davep opened this issue Feb 9, 2023 · 1 comment · Fixed by #1751
Assignees
Labels
enhancement New feature or request Task

Comments

@davep
Copy link
Contributor

davep commented Feb 9, 2023

This is essentially a sub-issue of #1725 but I feel it's one that should be done as a self-contained job and tracked as such. In anticipation of developing a more "traditional" style of checkbox, as well as a radio button, we're going to rename the current Checkbox (which is awesome but kinda chunky) to Switch.

This issue will track this renaming.

@davep davep added enhancement New feature or request Task labels Feb 9, 2023
@davep davep self-assigned this Feb 9, 2023
@darrenburns darrenburns changed the title Rename Checkbox to Swirtch Rename Checkbox to Switch Feb 9, 2023
davep added a commit to davep/textual that referenced this issue Feb 9, 2023
A new form of Checkbox will be arriving in Textual soon, working in
conjunction with a RadioButton. What was called Checkbox is perhaps a wee
bit heavyweight in terms of visual design, but is a style of widget that
should remain.

With this in mind we're renaming the current Checkbox to Switch. In all
other respects its workings remains the same, only the name has changed.

Things for people to watch out for:

- Imports will need to be updated.
- Queries will need to be updated; special attention will need to be paid to
  any queries that are string-based.
- CSS will need to be changed if any Checkbox styling is happening, or if
  any Checkbox component styles are being used.

See Textualize#1725 as the initial motivation and Textualize#1746 as the issue for this
particular change.
@davep davep linked a pull request Feb 9, 2023 that will close this issue
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant