A Widget-derived widget with inherit_bindings=False, but no BINDINGS, appears to still inherit bindings

[davep]

This is very much related to #1343, but I think merits an issue of its own to consider first. The reasons why this happens seem clear enough, but I feel the setup may cause confusion. With Textual as it is of 0.6.0 (with the bindings for movement keys being on Widget), consider this widget:

class Odradek( Widget, inherit_bindings=False ):
    pass

vs this:

class Odradek( Widget, inherit_bindings=False ):
    BINDINGS = []

In the former case the bindings of Widget are still inherited. In the latter they're not.

[willmcgugan]

Much the same issue as #1336

[rodrigogiraoserrao]

Much the same issue as #1336

So, you are saying that

textual/src/textual/dom.py

Line 232 in 338d74c

bindings.append(Bindings(base.BINDINGS))

should be base.__dict__.get("BINDINGS", []) instead of base.BINDINGS?

[rodrigogiraoserrao]

@davep I'll be happy to tackle this one.

[willmcgugan]

Yup. Suspect that will do it.

[davep]

@davep I'll be happy to tackle this one.

If you do, likely best to not start building up tests for it as I've just popped one for this exactly situation into #1346 and there's going to be more to come, that aren't the same issue but potentially overlap.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.