Skip to content

Commit

Permalink
Swap out the primary Markdown bullet for one that works everywhere (#…
Browse files Browse the repository at this point in the history
…1997)

* Swap out the primary Markdown bullet for one that works everywhere

The primary bullet wasn't displaying well on Windows in the Windows
terminal.

* Refresh the snapshot tests

Imagine that, changing how something looks needs that the snapshot tests get
updated. *facepalm*
  • Loading branch information
davep authored Mar 9, 2023
1 parent 44c7a3d commit a5695ed
Show file tree
Hide file tree
Showing 3 changed files with 134 additions and 133 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Updated styling to make it clear DataTable grows horizontally https://github.com/Textualize/textual/pull/1946
- Changed the `Checkbox` character due to issues with Windows Terminal and Windows 10 https://github.com/Textualize/textual/issues/1934
- Changed the `RadioButton` character due to issues with Windows Terminal and Windows 10 and 11 https://github.com/Textualize/textual/issues/1934
- Changed the `Markdown` initial bullet character due to issues with Windows Terminal and Windows 10 and 11 https://github.com/Textualize/textual/issues/1982

### Added

Expand Down
4 changes: 2 additions & 2 deletions src/textual/widgets/_markdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ class MarkdownBullet(Widget):
}
"""

symbol = reactive("●​")
symbol = reactive("\u25CF")
"""The symbol for the bullet."""

def render(self) -> Text:
Expand Down Expand Up @@ -500,7 +500,7 @@ class Markdown(Widget):
"""
COMPONENT_CLASSES = {"em", "strong", "s", "code_inline"}

BULLETS = [" ", "▪ ", "‣ ", "• ", "⭑ "]
BULLETS = ["\u25CF ", "▪ ", "‣ ", "• ", "⭑ "]

def __init__(
self,
Expand Down
Loading

0 comments on commit a5695ed

Please sign in to comment.