Custom message on Live overflow
#3702
Conversation
|
Bump @willmcgugan, could we at least run tests. (Curious why you don't allow tests to run for all PRs?) |
That used to be the case. Github changed it, and I haven't changed it back. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3702 +/- ##
==========================================
- Coverage 98.24% 97.98% -0.27%
==========================================
Files 74 74
Lines 8105 8147 +42
==========================================
+ Hits 7963 7983 +20
- Misses 142 164 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I am reluctant to add new parameters, as constructor signatures can get excessively large.
Since this parameter doesn't seem essential, how about an alternative way of configuring it? Perhaps a get_vertical_overflow_message method, so it could be customized in a subclass.
| @@ -59,7 +71,9 @@ def __init__( | |||
| transient: bool = False, | |||
| redirect_stdout: bool = True, | |||
| redirect_stderr: bool = True, | |||
| vertical_overflow: VerticalOverflowMethod = "ellipsis", | |||
| vertical_overflow: Union[ | |||
There was a problem hiding this comment.
I'm not keen on overloading a parameter like this. If it becomes a general purpose extension mechanism, it could quickly become unwieldy. I'd prefer to keep the message a separate value.
Type of changes
Checklist
Description
Allow a custom message with a
Liveoverflows, instead of an ellipsis.