Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): highlight columns added by add_row #3518

Conversation

TomJGooding
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3517. The default value for the Column.highlight is False, so where necessary columns are added by the add_row method this should default to the Table.highlight value.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (9c74f03) to head (16b3830).
Report is 83 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3518   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          74       74           
  Lines        8072     8098   +26     
=======================================
+ Hits         7931     7957   +26     
  Misses        141      141           
Flag Coverage Δ
unittests 98.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks Tom!

@willmcgugan willmcgugan merged commit 6607492 into Textualize:master Oct 4, 2024
20 checks passed
@TomJGooding TomJGooding deleted the fix-table-highlight-columns-added-by-add-row branch October 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Post 13.8.1 table automatic highlighting no longer works
3 participants