Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix split cells #3506

Merged
merged 6 commits into from
Sep 28, 2024
Merged

fix split cells #3506

merged 6 commits into from
Sep 28, 2024

Conversation

willmcgugan
Copy link
Collaborator

Fixed Segment._split_cells issue discovered in Textualize/textual#4996

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (9c74f03) to head (23c64f1).
Report is 29 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
+ Coverage   98.25%   98.26%   +0.01%     
==========================================
  Files          74       74              
  Lines        8072     8090      +18     
==========================================
+ Hits         7931     7950      +19     
+ Misses        141      140       -1     
Flag Coverage Δ
unittests 98.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan willmcgugan merged commit d5dcc74 into master Sep 28, 2024
21 checks passed
@willmcgugan willmcgugan deleted the fix-split-cells branch September 28, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants