-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New markdown parser #2439
Merged
Merged
New markdown parser #2439
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
f0ef11d
Map Markdown tokens to same format as old parser
darrenburns 85380a1
Handling inline styling elements and basic text
darrenburns 0ef4cc2
Slight refactor of Markdown parse code structure to make flow clearer
darrenburns 745bd99
Checking in progress
darrenburns a20c3d5
Support for headings
darrenburns 795b285
Add support for hardbreak
darrenburns 57ea4c3
Handle softbreaks
darrenburns 60cb12d
Add support for horizontal rule
darrenburns 7b92aed
Add support for links
darrenburns 9c70126
Add incomplete support for lists
darrenburns a295348
Add support for bullet lists
darrenburns 829cd5f
Support soft breaks
darrenburns d6a819f
Fix typo block_quote -> blockquote to support... blockquotes
darrenburns fb3113a
Work in progress image support
darrenburns b3d70df
Ensure we pop self-closing tags from the stack
darrenburns 73552a8
Add support for code blocks
darrenburns 4e09d67
Use more minimalistic styling for Markdown code blocks
darrenburns 219bf22
Switch off GFM markdown, manually enable tables (faster parsing)
darrenburns 32a7465
Merge branch 'master' of github.com:Textualize/rich into new-markdown…
darrenburns 7ce3d2a
Remove a bunch of commented out code
darrenburns 87807de
Remove linkify
darrenburns 90069d7
Remove test files from repo
darrenburns 9383774
Switching off links
darrenburns f21aed1
Remove redundant code
darrenburns c8fbd61
Support toggling links on and off
darrenburns 2e814de
Map inline code to correct style
darrenburns ecea70e
Support ordered list "start number"
darrenburns b472de3
Support highlighting inline code
darrenburns cf28a12
Fix a test, remove debugging stuff
darrenburns 4fecdd5
Remove unused code
darrenburns 2860e72
Fix mypy complaints
darrenburns 4787873
Fix some broken tests, remove redundant code
darrenburns df1ea6b
Remove dataclasses and types-dataclasses dependencies
darrenburns ea5faba
Re-add types dataclasses
darrenburns ca0aa4c
Lockfile
darrenburns c71a152
Remove a bunch of 3.6 stuff
darrenburns d029a81
Remove redundant line
darrenburns 22e70f0
Remove old comment
darrenburns 640c890
Some renaming, removing unused code
darrenburns 0999b40
Inline a closure that was no longer required
darrenburns 15c41e7
Un-fstring a string that shouldnt be an fstring
darrenburns 4760190
Remove mapping of tag to style names, just add new `markdown.*` style…
darrenburns 5516ed4
Update typing in Markdown to be stricter
darrenburns 0fdf3cf
Assert that the element popped on link_close is a Link
darrenburns 1c66120
Merge branch 'new-markdown-parser' of github.com:Textualize/rich into…
darrenburns 6dada68
Merge branch 'master' of github.com:Textualize/rich into new-markdown…
darrenburns 8e87818
Fix failing tests
darrenburns 73a9ec0
Fix Markdown link styling
darrenburns 644e0c0
Validate and fix some failed snapshot tests
darrenburns 421bd52
Remove some test Markdown files from repository
darrenburns d1813d2
Add CHANGELOG entry for commonmark -> markdown-it migration
darrenburns 3f316c5
Add support for strikethrough text
darrenburns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were missing 3.11.