Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce method complexity in InMemoryStorage #592

Merged
merged 3 commits into from
May 5, 2024

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented May 5, 2024

Refactor the check, if items should be included in the enumeration depending on the EnumerationOptions into a separate method to reduce the overall complexity.

@vbreuss vbreuss added the refactor A change or improvement without functional impact label May 5, 2024
@vbreuss vbreuss self-assigned this May 5, 2024
@vbreuss vbreuss force-pushed the topic/use-string-comparison-ordinal branch from a06f28a to 4d52417 Compare May 5, 2024 09:53
@vbreuss vbreuss marked this pull request as ready for review May 5, 2024 10:00
@vbreuss vbreuss enabled auto-merge (squash) May 5, 2024 10:00
Copy link

sonarqubecloud bot commented May 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented May 5, 2024

Stryker.NET mutation tested the changes in the pull request:
Mutation testing badge

@vbreuss vbreuss merged commit 09aaaf3 into main May 5, 2024
12 checks passed
@vbreuss vbreuss deleted the topic/use-string-comparison-ordinal branch May 5, 2024 10:12
Copy link

This is addressed in release v3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A change or improvement without functional impact state: released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant