Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set simulated EventArgs in FileSystemWatcherMock #582

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Apr 29, 2024

The FileSystemEventArgs implicitly combines the path in FullPath from its constructor arguments. When the file system is simulated, the directory separator char is incorrect.
When using the simulation mode, use reflection to correctly set the underlying backing field.

@vbreuss vbreuss added the bug Something isn't working label Apr 29, 2024
@vbreuss vbreuss self-assigned this Apr 29, 2024
@vbreuss vbreuss enabled auto-merge (squash) April 29, 2024 06:30
Copy link

Stryker.NET mutation tested the changes in the pull request:
Mutation testing badge

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@vbreuss vbreuss merged commit fb6c7fa into main Apr 29, 2024
12 checks passed
@vbreuss vbreuss deleted the topic/correctly-set-simulated-eventargs branch April 29, 2024 07:07
Copy link

github-actions bot commented May 5, 2024

This is addressed in release v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working state: released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant