Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement MockFile.ReadLinesAsync #935

Merged
merged 2 commits into from
Jan 24, 2023
Merged

feat: implement MockFile.ReadLinesAsync #935

merged 2 commits into from
Jan 24, 2023

Conversation

patricksadowski
Copy link
Contributor

While executing a test a got a hint:

System.NotImplementedException : This test helper hasn't been implemented yet. They are implemented on an as-needed basis. As it seems like you need it, now would be a great time to send us a pull request over at https://github.com/TestableIO/System.IO.Abstractions. You know, because it's open source and all.

So here is my pull request to add a not implemented feature. 😀

fgreinacher
fgreinacher suggested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the initiative @patricksadowski 🥇

Code changes look good, but the tests need a bit adaption.

@patricksadowski patricksadowski force-pushed the implement-mockfile-async branch from 2e3f18d to 7f47176 Compare January 20, 2023 06:47
@patricksadowski patricksadowski force-pushed the implement-mockfile-async branch from 7f47176 to 81be6bc Compare January 20, 2023 06:50
fgreinacher
fgreinacher approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 🙇 Let's get this in!

@mergify mergify bot merged commit 473e320 into TestableIO:main Jan 24, 2023
@github-actions
Copy link

This is addressed in release v19.1.13.

@github-actions github-actions bot added the state: released Issues that are released label Jan 31, 2023
vbreuss referenced this pull request in Testably/Testably.Abstractions Feb 13, 2023
@renovate
chore(deps): update dependency testableio.system.io.abstractions to v…
f510730 
…19.1.14 (#239)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.1.1` -> `19.1.14` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions</summary>

###
[`v19.1.14`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.14)

##### What's Changed

- feat: Add an explicit cast operator for FileSystemStream by
[@&#8203;Birnsen](https://togithub.com/Birnsen) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/940](https://togithub.com/TestableIO/System.IO.Abstractions/pull/940)

##### New Contributors

- [@&#8203;Birnsen](https://togithub.com/Birnsen) made their first
contribution in
[https://github.com/TestableIO/System.IO.Abstractions/pull/940](https://togithub.com/TestableIO/System.IO.Abstractions/pull/940)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.1.13...v19.1.14

###
[`v19.1.13`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.13)

##### What's Changed

- chore(deps): update dependency benchmarkdotnet to v0.13.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/928](https://togithub.com/TestableIO/System.IO.Abstractions/pull/928)
- chore(deps): update dependency moq to v4.18.4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/930](https://togithub.com/TestableIO/System.IO.Abstractions/pull/930)
- docs: mention related projects by
[@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/931](https://togithub.com/TestableIO/System.IO.Abstractions/pull/931)
- chore(deps): update dependency dotnet-sdk to v7.0.102 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/932](https://togithub.com/TestableIO/System.IO.Abstractions/pull/932)
- chore(deps): update dependency benchmarkdotnet to v0.13.4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/933](https://togithub.com/TestableIO/System.IO.Abstractions/pull/933)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.14 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/934](https://togithub.com/TestableIO/System.IO.Abstractions/pull/934)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.15 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/936](https://togithub.com/TestableIO/System.IO.Abstractions/pull/936)
- feat: implement MockFile.ReadLinesAsync by
[@&#8203;patricksadowski](https://togithub.com/patricksadowski) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/935](https://togithub.com/TestableIO/System.IO.Abstractions/pull/935)

##### New Contributors

- [@&#8203;patricksadowski](https://togithub.com/patricksadowski) made
their first contribution in
[https://github.com/TestableIO/System.IO.Abstractions/pull/935](https://togithub.com/TestableIO/System.IO.Abstractions/pull/935)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.1.5...v19.1.13

###
[`v19.1.5`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.5)

#### What's Changed

- chore(deps): update dependency dotnet-sdk to v7.0.101 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/924](https://togithub.com/TestableIO/System.IO.Abstractions/pull/924)
- chore(deps): update dependency microsoft.net.test.sdk to v17.4.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/925](https://togithub.com/TestableIO/System.IO.Abstractions/pull/925)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.13 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/926](https://togithub.com/TestableIO/System.IO.Abstractions/pull/926)
- fix: Fixing UNC path GetFullPath when Current Directory is a UNC path
by [@&#8203;michal-ciechan](https://togithub.com/michal-ciechan) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/887](https://togithub.com/TestableIO/System.IO.Abstractions/pull/887)

#### New Contributors

- [@&#8203;michal-ciechan](https://togithub.com/michal-ciechan) made
their first contribution in
[https://github.com/TestableIO/System.IO.Abstractions/pull/887](https://togithub.com/TestableIO/System.IO.Abstractions/pull/887)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.1.1...v19.1.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgreinacher fgreinacher fgreinacher approved these changes

Assignees
No one assigned
Labels
state: released Issues that are released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricksadowski @fgreinacher