Add internal, parameterless ctors for generated proxies #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@herebebeasties This is my take on #355. It's ugly but it works :/ |
herebebeasties
approved these changes
Sep 28, 2018
Mocking libraries, like Moq, are based on Castle.Core and rely on its functionality for generating dynamic proxies. This is only possible when there is an accessible parameterless constructor. This changes re-adds such constructors to several base types. They are marked internal and obsolete so that nobody accidentially uses them in "real" code. To allow Castle.Core to access them altough they are internal we expose our internals to the dynamic proxy assembly. Long-term we should expose interfaces instead of abstract classes at `IFileSystem`.
|
I added some tests to ensure that all properties exposed at |
yes! I absolutely agree on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocking libraries, like Moq, are based on
Castle.Core and rely on its functionality for
generating dynamic proxies. This is only possible
when there is an accessible parameterless constructor.
This changes re-adds such constructors to several
base types. They are marked internal and obsolete
so that nobody accidentially uses them in "real" code.
To allow Castle.Core to access them altough they are
internal we expose our internals to the dynamic proxy
assembly.
Long-term we should expose interfaces instead of
abstract classes at
IFileSystem.Fixes #355