fix: Throw correct exception if opening read-only file for writing #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock classes did not match .Net's behavior of throwing UnauthorizedAccessExceptions when opening readonly files with FileAccess.Write, making it impossible to test those scenarios. This commit fixes the mock classes so that the exception will be thrown correctly.
vbreuss
changed the title
vbreuss
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks, @WestRyanK for reporting and fixing this error.
I just slightly adapted the PR title, otherwise the pull request looks good to me and will be released shortly!
|
This is addressed in release v21.0.29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock classes did not match .net's behavior of throwing
UnauthorizedAccessExceptionwhen opening read-only files withFileAccess.Write, making it impossible to test those scenarios.This commit fixes the mock classes so that the exception will be thrown correctly.