-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save as > No "save" window opening #18
Comments
@tnrich, I can confirm that OVE is also not saving properly in macOS. |
Hey @IbanezP and @gmcarthuriv , thanks for raising this issue. I'll look into fixing this.. not sure why it broke. I need to figure out a good way to e2e-test the electron specific functionality. |
…g to use ipcRenderer correctly instead of deprecated electron.remote module
Hey @IbanezP and @gmcarthuriv I've published a new version (just did a republish) https://github.com/tnrich/ove-electron/releases/tag/v1.1.1 of ove-electron that should fix your issue. Let me know if it works for you. A few notes:
Cheers! |
Hi Thomas
Thanks a lot! I tried it on Windows 10 and it looks perfect!!!!
Few comments :
Default saving is .gb, but possible to save as .fasta .json and .bed
Shortcut works too
When using new feature, in the Notes section : spaces are replaced by
underscores (not a problem, but just to let you know)
Another question that might have to be set as a feature demand is actually
about features:
I have been massively using APE (
https://jorgensen.biology.utah.edu/wayned/ape/) that has this amazing
feature tool that allows you to create feature libraries (that you can
actually design using the app or directly using a CSV/txt file) to then
automatically annotate the sequences you deal with. I don't know if that is
already working on OVE or if it is planned somehow (I tried just now and
didn't manage, but I most likely don't know how to do it...).
Please let me know the best way to help in having this tool in OVE?
Thanks a lot for fixing the saving issue (I'll try soon on linux manjaro)
Take care
Pablo
Le lun. 26 avr. 2021 à 19:02, Thomas Rich ***@***.***> a
écrit :
… Hey @IbanezP <https://github.com/IbanezP> and @gmcarthuriv
<https://github.com/gmcarthuriv> I've published a new version
https://github.com/tnrich/ove-electron/releases/tag/v1.1.0 of
ove-electron that should fix your issue. Let me know if it works for you.
A few notes:
- Unfortunately I am unable to publish a linux version of the tool to
snapcraft due to snapcraft m1 incompatibilities (
https://forum.snapcraft.io/t/not-able-to-run-snapcraft-login-on-mac-m1/24001/3).
I think the AppImage should still work for linux though?
- I refactored how the main process and the renderer interact to
adhere to new electron best practices. The code should be cleaner and more
future proof now.
- Due to changes in how I initialize the renderer process it's
possible VERY large sequences wouldn't work with OVE electron but it is
unclear to me whether there is a limit here or not (
https://stackoverflow.com/questions/38335004/how-to-pass-parameters-from-main-process-to-render-processes-in-electron/59347064#comment118661293_59347064
)
- I wasn't able to find an easy way to test native dialog interactions
on electron and so have suspended the push to do so. I think it could be
done by stubbing all the functionality of the native dialogs but it seems
like a lot of effort to do it so I am holding off for now.
- This release includes a native m1 version of the app (ARM mac
download) and boy is it snapppppy!
Cheers!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVJV7MP3JTCYPM6N6IG5ITTKWMA7ANCNFSM42X5FUSA>
.
--
--
Pablo M. IBÁÑEZ CRUCEYRA, PhD
Postdoctoral Researcher
Andrew D. GRIFFITHS Lab
________
+--------------------------+
| ESPCI ParisTech |
+==========================+
| Laboratoire de Biochimie |
+--------------------------+
bâtiment B
2ème étage
porte B229
+------------------+
| 10 rue Vauquelin |
+==================+
| 75005 Paris |
+------------------+
| France |
+------------------+
Office: +33 (0) 1 40 79 45 87NEW Mobile: +33 (0) 7 78 70 57 17Email:
***@***.***NEW Jitsi:
https://meet.jit.si/PabloIbanezCruceyra________
École supérieure de physique et de chimie industrielles
de la Ville de Paris
10, rue Vauquelin | 75231 Paris Cedex 05 | France
+ 33 1 40 79 44 00https://www.espci.psl.eu/en/
--
|
thanks
done there
#17 (comment)
thanks again
Le mar. 27 avr. 2021 à 00:01, Thomas Rich ***@***.***> a
écrit :
… @IbanezP <https://github.com/IbanezP> sweet thanks for the report!
I think the best way to help a standalone auto annotation tool come to
fruition would be to add a bunch of screenshots (and descriptions)
detailing how this feature works in APE. You can add those onto this
existing issue: #17 <#17>
-Thomas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVJV7NTPRL6T2JQLN7WVCDTKXPCVANCNFSM42X5FUSA>
.
--
--
Pablo M. IBÁÑEZ CRUCEYRA, PhD
Postdoctoral Researcher
Andrew D. GRIFFITHS Lab
________
+--------------------------+
| ESPCI ParisTech |
+==========================+
| Laboratoire de Biochimie |
+--------------------------+
bâtiment B
2ème étage
porte B229
+------------------+
| 10 rue Vauquelin |
+==================+
| 75005 Paris |
+------------------+
| France |
+------------------+
Office: +33 (0) 1 40 79 45 87NEW Mobile: +33 (0) 7 78 70 57 17Email:
***@***.***NEW Jitsi:
https://meet.jit.si/PabloIbanezCruceyra________
École supérieure de physique et de chimie industrielles
de la Ville de Paris
10, rue Vauquelin | 75231 Paris Cedex 05 | France
+ 33 1 40 79 44 00https://www.espci.psl.eu/en/
--
|
@IbanezP I'm going to close this. Please still let me know how the linux install goes. Also, thanks for updating the auto annotate issue with the APE functionality! I'll check that out |
Thanks, @tnrich - working well on my end. |
I have tried under
Windows 10
and Manjaro (version installed through snap or through download and instructions on github (version 13.0.3)
none gives access to saving as...
Did I miss something?
Thanks
(ibanez.p.espci@gmail.com)
Operating System: Manjaro Linux
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.10.26-1-MANJARO
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-7200U CPU @ 2.50GHz
Memory: 15,5 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620
The text was updated successfully, but these errors were encountered: