cabana: fix QMenu leak (commaai#29956)

fix qmenu leak
Tes1a8 · Sep 18, 2023 · a450eff · a450eff
1 parent da4d4cf
commit a450eff
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/tools/cabana/messageswidget.cc b/tools/cabana/messageswidget.cc
@@ -424,7 +424,7 @@ void MessageView::updateBytesSectionSize() {
 }
 
 void MessageView::headerContextMenuEvent(const QPoint &pos) {
-  QMenu *menu = new QMenu(this);
+  QMenu menu(this);
   int cur_index = header()->logicalIndexAt(pos);
 
   QAction *action;
@@ -434,9 +434,9 @@ void MessageView::headerContextMenuEvent(const QPoint &pos) {
 
     // Hide show action
     if (header()->isSectionHidden(logical_index)) {
-      action = menu->addAction(tr("  %1").arg(column_name), [=]() { header()->showSection(logical_index); });
+      action = menu.addAction(tr("  %1").arg(column_name), [=]() { header()->showSection(logical_index); });
     } else {
-      action = menu->addAction(tr("✓ %1").arg(column_name), [=]() { header()->hideSection(logical_index); });
+      action = menu.addAction(tr("✓ %1").arg(column_name), [=]() { header()->hideSection(logical_index); });
     }
 
     // Can't hide the name column
@@ -450,7 +450,7 @@ void MessageView::headerContextMenuEvent(const QPoint &pos) {
     }
   }
 
-  menu->popup(header()->mapToGlobal(pos));
+  menu.exec(header()->mapToGlobal(pos));
 }
 
 MessageViewHeader::MessageViewHeader(QWidget *parent) : QHeaderView(Qt::Horizontal, parent) {