Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert difftool to use workflow panel #7532

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Convert difftool to use workflow panel #7532

wants to merge 4 commits into from

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Mar 6, 2025

What this PR does

Previously diff tool used a floating side panel design which was introduced before we had WorkflowPanel. This PR updates the difftool to use the WorkflowPanel and makes it more consistent with the new UI changes introduced in #7443.

Before:
image

After:
image

Test me

  • Run the difference workflow from main and this branch for the item in the workbench.
    image

  • Make sure that the functionality and outputs remain unchanged

  • Make sure there are no errors

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@ljowen
Copy link
Contributor

ljowen commented Mar 6, 2025

Looks great, that was quick!
Screenshot 2025-03-06 at 2 38 48 pm

Would be good to get @AmberStandley83 's thoughts on wording here, maybe "Back" could be "Edit" or "Close" could be "Save" or "Ok", right now it's not clear which one is taking me to the workbench vs the first panel.

Down the track if we're going to have multistep workflows a "wizard" style UI could be used here but thats for a later date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Diff tool to workflow
2 participants