Wc weblate #5478
Wc weblate #5478
Conversation
There was a problem hiding this comment.
This is great @wibily. Thanks so much for researching all of this and setting it up. Here's a few things that I picked up on.
| @@ -0,0 +1,27 @@ | |||
| # 7. Use weblate for i18n | |||
|
|
|||
| Date: 2020-05-07 | |||
|
|
||
| We will use hosted weblate at https://hosted.weblate.org/projects/terriajs/ to allow external translators to contribute to the project. There will be two projects, one connected to the master branch and another connected to the next branch. | ||
|
|
||
| When the en/translation.json is updated, our weblate plugin and associated webhook will let the hosted weblate know and weblate will pull the updated changes. When a contributing translator provides translations, weblate will create a PR into the corresponding branch allowing a terria mainter to review the changes before merging the changes. |
There was a problem hiding this comment.
There was a problem hiding this comment.
I see that weblate has a mechanism to review translations. I am not sure who is in charge of reviewing, but I wonder when we get entire terriajs translated to French and approve those translations. When some source string changes, will it set its translation to unreviewed or need editing status?
There was a problem hiding this comment.
@steve9164 New whole translation files won't be an issue as it'll get picked up by the github webhook and then it'll follow the existing weblate process. If it was an existing translation file however, this might cause merge conflicts between our respository and the weblate repository.
@zoran995 - I believe that if the source string changes, it will change the status of the translated string to 'needs editing'.
There was a problem hiding this comment.
Just checked above with weblate support to be sure. When source strings update, their state will change automatically to "Needs editing", and if we are using reviewing new review will be required. Can we add that somewhere to adr, and also, should reviewing be activated?
There was a problem hiding this comment.
Keep in mind that we will need additional work to support RTL languages currently
There was a problem hiding this comment.
I don't think we should enable reviewing at this stage, maybe once we have identified someone who could do it? Thoughts? @steve9164
|
In the context of using weblate and translating to french, we should address strings from #4519 (with or without lint support), since some strings are still not extracted for translation. |
Co-authored-by: Stephen Davies <steve9164@gmail.com>
…e strings and bulk imports of new languages
What this PR does
records down the decision to use weblate for our translation needs
Checklist