Adding S3 Endpoint Config Option #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for custom S3 endpoints to be added to the server config. Co-Authored-By: Michael Izatt <59045460+michaelizatt@users.noreply.github.com>
Altered implementation for easier readability.
|
Tested and Functional with Digital Ocean Spaces |
pjonsson
reviewed
Nov 24, 2024
|
I can't test this PR right now, but I have local patches on TerriaMap to get the same effect, so it would be nice to have this PR merged. |
Indentation converted to 4 spaces as apposed to 2 based on @pjonsson review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for custom S3 endpoints to be added to the server config.
This pull request includes updates to the S3 configuration in the
lib/controllers/share.jsfile and theserverconfig.json.examplefile to support custom S3 endpoints. These changes enhance the flexibility of the S3 service configuration.Configuration updates:
lib/controllers/share.js: Added support for a custom S3 endpoint by updating the AWS configuration to include theendpointoption if provided inserviceOptions.serverconfig.json.example: Added an optionalendpointfield to allow users to specify a custom S3 endpoint in the configuration file.