Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCM datasets does not show instrument mode #52

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

xmichele
Copy link
Contributor

@xmichele xmichele commented Mar 27, 2024

ESACPE-1399
RCM datasets do not report the SAR mode [sar:instrument_mode] in the title as per rule:

[platformLabel] [sar:product_type] [sar:instrument_mode] [sar:polarizations] [datetime {ISO8601-TZ}]

In addition the field is empty in the stac Item

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 10.86%. Comparing base (e98f1f9) to head (be716da).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #52   +/-   ##
========================================
  Coverage    10.86%   10.86%           
========================================
  Files          240      240           
  Lines        35726    35725    -1     
  Branches      3156     3158    +2     
========================================
+ Hits          3880     3882    +2     
+ Misses       31846    31843    -3     
Flag Coverage Δ
unittests 10.86% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rs.Data/Model/Metadata/RCM/RcmMetadataExtractor.cs 12.83% <25.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

@xmichele xmichele changed the title ESACPE-1399 RCM datasets does not show instrument mode Mar 28, 2024
@emmanuelmathot emmanuelmathot merged commit 471cc44 into Terradue:develop Mar 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants