styling

src/.editorconfig

@@ -407,11 +407,14 @@ dotnet_diagnostic.SA1119.severity = warning      # Statement must not use unnece
 dotnet_diagnostic.SA1124.severity = warning      # Do not use regions
 dotnet_diagnostic.SA1127.severity = warning      # Generic type constraints must be on their own line or share line with previous
 dotnet_diagnostic.SA1128.severity = warning      # Put constructor initializers on their own line
+dotnet_diagnostic.SA1137.severity = warning      # Elements should have the same indentation
 dotnet_diagnostic.SA1201.severity = warning      # Elements must appear in the correct order
+dotnet_diagnostic.SA1214.severity = warning      # Readonly fields must appear before non-readonly fields
 dotnet_diagnostic.SA1501.severity = warning      # Braces must not be omitted
 dotnet_diagnostic.SA1503.severity = warning      # Braces must not be omitted
 dotnet_diagnostic.SA1506.severity = warning      # Element documentation header must not be preceded by blank line
 dotnet_diagnostic.SA1507.severity = warning      # Code should not contain multiple blank lines in a row
+dotnet_diagnostic.SA1508.severity = warning      # A closing brace must not be preceded by a blank line
 dotnet_diagnostic.SA1513.severity = warning      # Closing brace must be followed by blank line
 dotnet_diagnostic.SA1514.severity = warning      # Element documentation header must be preceded by blank line
 dotnet_diagnostic.SA1515.severity = warning      # Single-line comment must be preceded by blank line

src/DotNetStac/Collection/IStacSummaryItem.cs

@@ -36,6 +36,5 @@ public interface IStacSummaryItem : IEnumerable<JToken>
         /// The summary item as a JToken
         /// </value>
         IEnumerable<object> Enumerate();
-
     }
 }

src/DotNetStac/Collection/StacExtent.cs

@@ -32,7 +32,7 @@ public StacExtent(StacSpatialExtent spatial, StacTemporalExtent temporal)
         /// Initializes a new instance of the <see cref="StacExtent"/> class.
         /// Initialize a new Stac Extent from an existing one (clone).
         /// </summary>
-        /// <param name="extent"></param>
+        /// <param name="extent">The extent.</param>
         public StacExtent(StacExtent extent)
         {
             this.Spatial = new StacSpatialExtent(extent.Spatial);
@@ -65,11 +65,11 @@ public static StacExtent Create(IEnumerable<StacItem> items)
             minDate = minDate == DateTime.MinValue ? null : minDate;
             maxDate = maxDate == DateTime.MaxValue ? null : maxDate;
             return new StacExtent(
-                new StacSpatialExtent(
+                new StacSpatialExtent(
                     items.Min(i => i.GetBoundingBoxFromGeometryExtent()[0]),
-                                                items.Min(i => i.GetBoundingBoxFromGeometryExtent()[1]),
-                                                items.Max(i => i.GetBoundingBoxFromGeometryExtent()[2]),
-                                                items.Max(i => i.GetBoundingBoxFromGeometryExtent()[3])),
+                    items.Min(i => i.GetBoundingBoxFromGeometryExtent()[1]),
+                    items.Max(i => i.GetBoundingBoxFromGeometryExtent()[2]),
+                    items.Max(i => i.GetBoundingBoxFromGeometryExtent()[3])),
 
                 new StacTemporalExtent(minDate, maxDate)
             );
@@ -83,24 +83,24 @@ public object Clone()
 
         internal void Update(ICollection<StacItem> items)
         {
-            this.Spatial = new StacSpatialExtent(
+            this.Spatial = new StacSpatialExtent(
                 items.Select(i => i.GetBoundingBoxFromGeometryExtent()[0])
                                                  .Concat(new double[] { this.Spatial.BoundingBoxes[0][0] })
                                                  .Min(),
-                                            items.Select(i => i.GetBoundingBoxFromGeometryExtent()[1])
+                items.Select(i => i.GetBoundingBoxFromGeometryExtent()[1])
                                                  .Concat(new double[] { this.Spatial.BoundingBoxes[0][1] })
                                                  .Min(),
-                                            items.Select(i => i.GetBoundingBoxFromGeometryExtent()[2])
+                items.Select(i => i.GetBoundingBoxFromGeometryExtent()[2])
                                                  .Concat(new double[] { this.Spatial.BoundingBoxes[0][2] })
                                                  .Max(),
-                                            items.Select(i => i.GetBoundingBoxFromGeometryExtent()[3])
+                items.Select(i => i.GetBoundingBoxFromGeometryExtent()[3])
                                                  .Concat(new double[] { this.Spatial.BoundingBoxes[0][3] })
                                                  .Max());
-            this.Temporal = new StacTemporalExtent(
+            this.Temporal = new StacTemporalExtent(
                 items.Select(i => i.DateTime.Start)
                                                    .Concat(new DateTime[] { this.Temporal.Interval[0][0].GetValueOrDefault() })
                                                    .Min(),
-                                              items.Select(i => i.DateTime.End)
+                items.Select(i => i.DateTime.End)
                                                    .Concat(new DateTime[] { this.Temporal.Interval[0][1].GetValueOrDefault() })
                                                    .Max());
         }

src/DotNetStac/Collection/StacSummaryItem.cs

@@ -61,6 +61,5 @@ IEnumerator<JToken> IEnumerable<JToken>.GetEnumerator()
         {
             return this.summary.Children().GetEnumerator();
         }
-
     }
 }

src/DotNetStac/Common/Statistics.cs

@@ -87,6 +87,5 @@ public Statistics(double? minimum, double? maximum, double? mean, double? stdev,
         /// </value>
         [JsonExtensionData]
         public IDictionary<string, object> Properties { get => this.properties; set => this.properties = value; }
-
     }
 }

src/DotNetStac/Exceptions/InvalidStacSchemaException.cs

@@ -7,23 +7,43 @@
 
 namespace Stac.Exceptions
 {
+    /// <summary>
+    /// Exception thrown when the STAC schema is invalid
+    /// </summary>
     [Serializable]
     public class InvalidStacSchemaException : Exception
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidStacSchemaException"/> class.
+        /// </summary>
         public InvalidStacSchemaException()
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidStacSchemaException"/> class.
+        /// </summary>
+        /// <param name="message">The message that describes the error.</param>
         public InvalidStacSchemaException(string message)
             : base(message)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidStacSchemaException"/> class.
+        /// </summary>
+        /// <param name="message">The message that describes the error.</param>
+        /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (Nothing in Visual Basic) if no inner exception is specified.</param>
         public InvalidStacSchemaException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="InvalidStacSchemaException"/> class.
+        /// </summary>
+        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
+        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
         protected InvalidStacSchemaException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {

src/DotNetStac/Extensions/Alternate/AlternateAssetObject.cs

@@ -15,8 +15,8 @@ namespace Stac.Extensions.Alternate
     [JsonObject(ItemNullValueHandling = NullValueHandling.Ignore)]
     public class AlternateAssetObject : IStacPropertiesContainer
     {
-        private string href;
         private readonly IStacObject _parent;
+        private string href;
         private string title;
 
         private string description;

src/DotNetStac/Extensions/Alternate/AlternateStacExtension.cs

@@ -76,7 +76,6 @@ public AlternateAssetObject AddAlternate(string key, Uri uri, string title = nul
             this.AlternateAssets = alternateAssets;
             return alternateAssetObject;
         }
-
     }
 
     /// <summary>

src/DotNetStac/Extensions/Datacube/DatacubeDimensionObject.cs

@@ -149,7 +149,6 @@ public class DatacubeDimensionTemporal : DatacubeDimension
         public DatacubeDimensionTemporal()
             : base()
         {
-
         }
     }
 
@@ -162,7 +161,6 @@ public class DatacubeDimensionAdditional : DatacubeDimension
         public DatacubeDimensionAdditional()
             : base()
         {
-
         }
 
         /// <summary>

src/DotNetStac/Extensions/Eo/EoBandObject.cs

@@ -95,6 +95,5 @@ public EoBandObject(string name, EoBandCommonName? commonName)
         /// </value>
         [JsonExtensionData]
         public IDictionary<string, object> Properties { get => this.properties; set => this.properties = value; }
-
     }
 }

src/DotNetStac/Extensions/File/ByteOrder.cs

@@ -21,6 +21,5 @@ public enum ByteOrder
         // Little Endian
         [EnumMember(Value = "little-endian")]
         LittleEndian
-
     }
 }

src/DotNetStac/Extensions/File/FileStacExtension.cs

@@ -104,7 +104,6 @@ public override IDictionary<string, ISummaryFunction> GetSummaryFunctions()
             Dictionary<string, ISummaryFunction> summaryFunctions = new Dictionary<string, ISummaryFunction>();
             return summaryFunctions;
         }
-
     }
 
     /// <summary>
@@ -127,9 +126,9 @@ public static FileStacExtension FileExtension(this StacAsset stacAsset)
         /// </summary>
         public static async Task SetFileExtensionProperties(
             this FileStacExtension fileStacExtension,
-                                                      FileInfo file,
-                                                      HashType hashType = HashType.SHA1,
-                                                      MultibaseEncoding encoding = MultibaseEncoding.Base16Lower)
+            FileInfo file,
+            HashType hashType = HashType.SHA1,
+            MultibaseEncoding encoding = MultibaseEncoding.Base16Lower)
         {
             fileStacExtension.Size = Convert.ToUInt64(file.Length);
             await fileStacExtension.SetFileCheckSum(hashType, encoding, uri => file.OpenRead());
@@ -142,9 +141,9 @@ public static async Task SetFileExtensionProperties(
         /// </summary>
         public static async Task SetFileExtensionProperties(
             this FileStacExtension fileStacExtension,
-                                                      Stream stream,
-                                                      HashType hashType = HashType.SHA1,
-                                                      MultibaseEncoding encoding = MultibaseEncoding.Base16Lower)
+            Stream stream,
+            HashType hashType = HashType.SHA1,
+            MultibaseEncoding encoding = MultibaseEncoding.Base16Lower)
         {
             await fileStacExtension.SetFileCheckSum(hashType, encoding, uri => stream);
         }
@@ -154,9 +153,9 @@ public static async Task SetFileExtensionProperties(
         /// </summary>
         public static async Task SetFileCheckSum(
             this FileStacExtension fileStacExtension,
-                                                         HashType hashType,
-                                                         MultibaseEncoding encoding,
-                                                         Func<Uri, Stream> uriStreamer)
+            HashType hashType,
+            MultibaseEncoding encoding,
+            Func<Uri, Stream> uriStreamer)
         {
             Multihash mh = null;
             using (var stream = uriStreamer(fileStacExtension.StacAsset.Uri))

src/DotNetStac/Extensions/ItemCollection/ItemCollection.cs

@@ -18,12 +18,12 @@ public class ItemCollection : StacCollection, IStacExtension
 
         public ItemCollection(
             string id,
-                              string description,
-                              List<StacItem> stacItems)
+            string description,
+            List<StacItem> stacItems)
             : base(
                 id,
-                                                               description,
-                                                               null)
+                description,
+                null)
         {
             if (stacItems != null)
             {
@@ -83,23 +83,23 @@ internal static JSchema GenerateJSchema(string version)
                     { "stac_version", new JSchema(){
                         Title = "STAC version",
                         Type = JSchemaType.String
-                    }},
+                    }                    },
                     { "stac_extensions", new JSchema(){
                         Title = "STAC extensions",
                         Type = JSchemaType.Array,
                         UniqueItems = true,
                         Items = { new JSchema { Type = JSchemaType.String, Format = "uri", Title = "Reference to a JSON Schema" } }
-                    }},
+                    }                    },
                     { "features", new JSchema(){
                         Title = "ItemCollection features",
                         Type = JSchemaType.Array,
                         Items = { new JSchema { Ref = itemSchema } }
-                    }},
+                    }                    },
                     { "links", new JSchema(){
                         Title = "Links",
                         Type = JSchemaType.Array,
                         Items = { new JSchema { Ref = linkSchema } }
-                    }},
+                    }                    },
                 }
             });
 

src/DotNetStac/Extensions/Processing/ProcessingStacExtension.cs

@@ -107,7 +107,6 @@ private void UpdateSoftwareField(object sender, NotifyCollectionChangedEventArgs
             this.StacPropertiesContainer.SetProperty(SoftwareField, new Dictionary<string, string>(sender as IDictionary<string, string>));
             this.DeclareStacExtension();
         }
-
     }
 
     /// <summary>
@@ -128,9 +127,9 @@ public static ProcessingStacExtension ProcessingExtension(this StacItem stacItem
         /// </summary>
         public static void Init(
             this ProcessingStacExtension processingStacExtension,
-                                string lineage,
-                                string level,
-                                string facility = null)
+            string lineage,
+            string level,
+            string facility = null)
         {
             processingStacExtension.Lineage = lineage;
             processingStacExtension.Level = level;

src/DotNetStac/Extensions/Sar/SarStacExtension.cs

@@ -147,16 +147,15 @@ public static StacAsset GetAsset(this StacItem stacItem, string polarization)
 
         public static void Required(
             this SarStacExtension sarStacExtension,
-                                string instrumentMode,
-                                SarCommonFrequencyBandName frequencyBandName,
-                                string[] polarizations,
-                                string productType)
+            string instrumentMode,
+            SarCommonFrequencyBandName frequencyBandName,
+            string[] polarizations,
+            string productType)
         {
             sarStacExtension.InstrumentMode = instrumentMode;
             sarStacExtension.FrequencyBand = frequencyBandName;
             sarStacExtension.Polarizations = polarizations;
             sarStacExtension.ProductType = productType;
         }
     }
-
 }

src/DotNetStac/Extensions/Sat/BaselineCalculation.cs

@@ -193,7 +193,6 @@ public static BaselineVector CalculateBaseline(DateTime[] time, SatOrbitStateVec
             double bAlong = b[0] * vaUnit[0] + b[1] * vaUnit[1] + b[2] * vaUnit[2];
 
             return new BaselineVector(bPerp, bParallel, bAlong);
-
         }
 
         public static double[] VectorProduct3D(double[] vectorA, double[] vectorB)
@@ -279,7 +278,6 @@ private static double GetOrbitValue(double time, IInterpolation[] interpol, int
         {
 
             return interpol[index].Interpolate(time);
-
         }
 
         //---------------------------------------------------------------------------------------------------------------------
@@ -320,9 +318,6 @@ public static IInterpolation[] PolyInterpol(DateTime time0, SatOrbitStateVector[
             coeff[8] = Interpolate.CubicSplineRobust(time, az1.ToArray());
 
             return coeff;
-
         }
-
     }
-
 }

src/DotNetStac/Extensions/Sat/BaselineVector.cs

@@ -31,5 +31,4 @@ public double Along
             get { return this.along; }
         }
     }
-
 }

src/DotNetStac/Extensions/Sat/SatStacExtension.cs

@@ -102,7 +102,6 @@ private SortedDictionary<DateTime, SatOrbitStateVector> SortOrbitStateVectors(JT
 
             return new SortedDictionary<DateTime, SatOrbitStateVector>(osvlist.ToDictionary(osv => osv.Time, osv => osv));
         }
-
     }
 
     public static class SatStacExtensionExtensions

src/DotNetStac/Extensions/Sat/SatStacExtensionHelpers.cs

@@ -37,7 +37,6 @@ public static BaselineVector CalculateBaseline(this SatStacExtension sat1, SatSt
             var baseline = BaselineCalculation.CalculateBaseline(times, masterOrbits.ToArray(), slaveOrbits.ToArray(), p0);
 
             return baseline;
-
         }
     }
 }