more cleanup

src/DotNetStac.Test/Schemas/SchemaLoaderTests.cs

@@ -0,0 +1,19 @@
+using Stac.Extensions.Sat;
+using Newtonsoft.Json;
+using Xunit;
+using Stac.Extensions;
+using Stac.Exceptions;
+
+namespace Stac.Test.Item
+{
+    public class SchemaLoaderTests : TestBase
+    {
+        [Fact]
+        public void ThrowInvalidExtensionShortcut()
+        {
+            Assert.Throws<InvalidStacSchemaException>(() => SchemaBasedStacExtension.Create("item", null, null));
+
+        }
+
+    }
+}

src/DotNetStac/Collection/IStacSummaryItem.cs

@@ -7,8 +7,6 @@ namespace Stac.Collection
 {
     public interface IStacSummaryItem : IEnumerable<JToken>
     {
-        SummaryItemType SummaryType { get; }
-
         JToken this[object key] { get; }
 
         JToken AsJToken { get; }

src/DotNetStac/Collection/StacSummaryItem.cs

@@ -22,8 +22,6 @@ public JToken this[object key]
             }
         }
 
-        public abstract SummaryItemType SummaryType { get; }
-
         public JToken AsJToken => summary;
 
         public IEnumerator GetEnumerator()

src/DotNetStac/Collection/StacSummaryStatsObject.cs

@@ -11,7 +11,7 @@ public class StacSummaryStatsObject<T> : StacSummaryItem
         public StacSummaryStatsObject(JObject summary) : base(summary)
         {
             if (!summary.ContainsKey("minimum") || !summary.ContainsKey("maximum"))
-                throw new ArgumentException("summary stats must contains min and max");
+                throw new ArgumentException("summary stats must contains minimum and maximum fields");
         }
 
         public StacSummaryStatsObject(T min, T max) : base(new JObject())
@@ -24,8 +24,6 @@ public StacSummaryStatsObject(T min, T max) : base(new JObject())
 
         public T Max { get => summary["maximum"].Value<T>(); set => summary["maximum"] = new JValue(value); }
 
-        public override SummaryItemType SummaryType => SummaryItemType.StatsObject;
-
 
     }
 }

src/DotNetStac/Collection/StacSummaryValueSet.cs

@@ -23,8 +23,6 @@ public void Add(T item){
             ((JArray)summary).Add(item);
         }
 
-        public override SummaryItemType SummaryType => SummaryItemType.ValueSet;
-
         public int Count => summary.Count();
 
         public IEnumerable<T> SummarySet { get => summary.ToObject<List<T>>(); } 

src/DotNetStac/Exceptions/InvalidStacSchemaException.cs

@@ -4,7 +4,7 @@
 namespace Stac.Exceptions
 {
     [Serializable]
-    internal class InvalidStacSchemaException : Exception
+    public class InvalidStacSchemaException : Exception
     {
         public InvalidStacSchemaException()
         {