proper StacItem Clone

Terradue · Nov 25, 2020 · 06225ba · 06225ba
1 parent 555f388
commit 06225ba
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/DotNetStac/Extensions/StacExtensions.cs b/src/DotNetStac/Extensions/StacExtensions.cs
@@ -7,7 +7,7 @@
 
 namespace Stac.Extensions
 {
-    public class StacExtensions : Dictionary<string, IStacExtension>
+    public class StacExtensions : Dictionary<string, IStacExtension>, IEnumerable<IStacExtension>
     {
         public StacExtensions(IEnumerable<IStacExtension> stacExtensions = null)
         {
@@ -33,7 +33,9 @@ public void Add(IStacExtension extension)
             Add(extension.Id, extension);
         }
 
-
-
+        IEnumerator<IStacExtension> IEnumerable<IStacExtension>.GetEnumerator()
+        {
+            return this.Values.GetEnumerator();
+        }
     }
 }
diff --git a/src/DotNetStac/Item/StacItem.Model.cs b/src/DotNetStac/Item/StacItem.Model.cs
@@ -40,16 +40,16 @@ public StacItem(IGeometryObject geometry, object properties, string id = null) :
         }
 
         public StacItem(StacItem stacItem) : this(Preconditions.CheckNotNull(stacItem).Geometry, 
-                                                  Preconditions.CheckNotNull(stacItem).Properties, 
+                                                  new Dictionary<string, object>(Preconditions.CheckNotNull(stacItem).Properties), 
                                                   Preconditions.CheckNotNull(stacItem).Id)
         {
             this.stacExtensionsStrings = stacItem.stacExtensionsStrings;
             this.stacVersion = stacItem.stacVersion;
-            this.links = stacItem.links;
-            this.assets = stacItem.assets;
+            this.links = new Collection<StacLink>(stacItem.links);
+            this.assets = new Dictionary<string, StacAsset>(stacItem.assets);
             this.collection = stacItem.collection;
             this.sourceUri = stacItem.sourceUri;
-            this.extensions = stacItem.extensions;
+            this.extensions = new StacExtensions(stacItem.extensions);
         }
 
         [JsonProperty("stac_extensions")]