Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: introducing JDK Mission Control's JMX Console #3

Merged
merged 8 commits into from
Jan 1, 2022
Merged

Conversation

keturn
Copy link
Contributor

@keturn keturn commented Nov 17, 2021

This documents the feature added in MovingBlocks/Terasology#4947

View the document in this PR on Jenkins: Monitoring Metrics with JMC

TODO

Before Merging

  • re-render demo video and poster
  • finish documentation on setting JMC connection parameters

For Later

  • remote connection forwarding or encryption
  • configuration for servers started by Launcher

@keturn
Copy link
Contributor Author

keturn commented Nov 17, 2021

I was trying to keep the demo clip under a megabyte, but I'm not sure I'm happy with the tradeoffs I made.

It's 720p now, but the docsify content width is narrow enough that it doesn't show at full size. I could drop the resolution down a notch (maybe 1024px wide?), and cut the length from 30s down to 10–15s and it would probably still be as useful. Then I'd have more room to up the quality so it's not so blurry and blocky.

@keturn
Copy link
Contributor Author

keturn commented Nov 20, 2021

micrometer & JMX

Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and helped me get started with connecting to a local instance.

Whatever is missing or still quirky, we can improve on the go.

@keturn I'm not sure whether to merge this right now as this is still a draft and has an open todo item. As stated above, I'm fine with merging, but I leave this to you.

docs/Monitoring Metrics with JMC - JDK Mission Control.md Outdated Show resolved Hide resolved
Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdrueckert you may want to have a look at this, or at least keep it in mind that we may want to try this out for the next playtest event.

@keturn keturn marked this pull request as ready for review January 1, 2022 02:49
@keturn keturn merged commit a9eb345 into master Jan 1, 2022
@keturn keturn deleted the feat/jmx branch January 1, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants