chore: remove fireball duplicates and reference CombatSystem:fireBall #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the projectiles are in fact mostly duplicates of
CombatSystem:fireBall
and only change the amount of damage as well as add ahurtingType
that is not used anywhere.I am aware, that this was done in preparation to create different types of staffs that can be used to enhance the LaS gameplay. However, most of the planned-for staff effects are unlikely to use "normal" projectiles in the first place. Also, LaS needs some work, before that kind of content logic additions can be taken up again.
So I vote for removing the duplicates and have the staffs simply reference
CombatSystem:fireBall
for the time being instead of duplicating the projectile prefab including the reference to theCombatSystem:ballSpell
mesh that is extracted to engine in MovingBlocks/Terasology#5000