Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove fireball duplicates and reference CombatSystem:fireBall #81

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

jdrueckert
Copy link
Member

I noticed that the projectiles are in fact mostly duplicates of CombatSystem:fireBall and only change the amount of damage as well as add a hurtingType that is not used anywhere.

I am aware, that this was done in preparation to create different types of staffs that can be used to enhance the LaS gameplay. However, most of the planned-for staff effects are unlikely to use "normal" projectiles in the first place. Also, LaS needs some work, before that kind of content logic additions can be taken up again.

So I vote for removing the duplicates and have the staffs simply reference CombatSystem:fireBall for the time being instead of duplicating the projectile prefab including the reference to the CombatSystem:ballSpell mesh that is extracted to engine in MovingBlocks/Terasology#5000

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Type: Chore Request for or implementation of maintenance changes labels Mar 6, 2022
@jdrueckert jdrueckert requested review from skaldarnar and ujjman March 6, 2022 13:55
@skaldarnar skaldarnar merged commit d9bac21 into develop Mar 6, 2022
@skaldarnar skaldarnar deleted the chore/remove-fireball-duplicates branch March 6, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants