Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up test prefabs #90

Merged
merged 4 commits into from
Jan 21, 2022
Merged

chore: clean up test prefabs #90

merged 4 commits into from
Jan 21, 2022

Conversation

jdrueckert
Copy link
Member

  • remove unused test prefabs
  • remove unnecessary components from test character
  • add MinionMove component to test character in test instead of overwriting it
  • move testcharacter.prefab into assets/prefabs/test

Part of MovingBlocks/Terasology#4981
Follow-up for #89

@jdrueckert
chore: remove unused test prefabs
1fc545b
@jdrueckert
chore: remove unnecessary components from test character
ec5bd2f
@jdrueckert
refactor: add MinionMove component to test character in test instead …
ac3c414 
…of overriding it

- the contents of the MinionMove component as defined in the testcharacter.prefab are overwritten in the MovementTests using the prefab
- newly create and add the MinionMove component in the test setup instead
@jdrueckert
chore: move testcharacter.prefab into assets/prefabs/test
e3f6636
@jdrueckert jdrueckert added Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Type: Chore Request for or implementation of maintenance changes Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Jan 21, 2022
@jdrueckert jdrueckert requested a review from skaldarnar January 21, 2022 19:01
@jdrueckert jdrueckert self-assigned this Jan 21, 2022
@jdrueckert jdrueckert merged commit 571c1cd into develop Jan 21, 2022
@jdrueckert jdrueckert deleted the chore/testcharacter-cleanup branch January 21, 2022 19:12
@jdrueckert jdrueckert mentioned this pull request Jan 21, 2022
Closed
14 tasks
@jdrueckert
Copy link
Member Author

FlexibleMovement as a replacement for PathFinding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees

@jdrueckert jdrueckert

Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Type: Chore Request for or implementation of maintenance changes Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @skaldarnar