feat!: Replace Pathfinding with FlexiblePathfinding (part 2) (#89)

* feat!: integrate classes from FlexibleMovement
* feat!: add assets from FlexibleMovement
* chore!: remove left-over actions using Pathfinding
* chore!: remove behavior node prefabs that got a replacement
* chore!: remove dead code and broken references
* chore: rename all remaining occurrences of FlexibleMovementComponent to MinionMoveComponent

* test: add descriptions to BehaviorTests
* test: fix test by waiting for chunk generation

Co-authored-by: Josephine Rueckert <jd.rueckert@googlemail.com>

assets/behaviors/common/attackFollowedEntity.behavior

@@ -23,7 +23,7 @@
                     }
                   }
                 },
-                move_to
+               move_to
               ]
             }
           ]

assets/behaviors/common/doRandomMove.behavior

@@ -3,7 +3,7 @@
   {
     set_target_nearby_block : { moveProbability: 65 }
   },
-    move_to
+   move_to
   ]
 }
 

assets/behaviors/common/follow.behavior

@@ -28,7 +28,7 @@
             }
           }
         },
-        move_to
+       move_to
       ]
     },
     {

assets/behaviors/common/restrictedStray.behavior

@@ -15,7 +15,7 @@
                     set_target_nearby_block_restricted : { moveProbability: 65 }
                 },
                 {
-                    move_to: { distance:  2}
+                   move_to: { distance:  2}
                 }
             ]
         },

assets/behaviors/creatures/worker.behavior

@@ -1,7 +1,7 @@
 {
   sequence: [
     {
-      move_to: {
+     move_to: {
         distance: 0.7
       }
     },

assets/behaviors/naiveMoveTo.behavior

@@ -0,0 +1,15 @@
+{
+  sequence : [
+    {
+      selector : [
+        find_path
+      ]
+    },
+    { move_along_path: {
+      child : {
+        move_to: {}
+      }
+     }
+    }
+  ]
+}

assets/behaviors/pathfinding/dynamicPathfindingFollow.behavior

@@ -17,14 +17,13 @@
                     sequence: [
                         set_target_to_followed_entity,
                         find_path,
-                        setup_continuous_pathfinding,
                         {
                             timeout: {
                                 time: 3,
                                 child: {
-                                    move_along_path_continuous: {
+                                    move_along_path: {
                                         child: {
-                                            move_to: {}
+                                           move_to: {}
                                         }
                                     }
                                 }

assets/behaviors/pathfinding/pointPathfindingFollow.behavior

@@ -19,7 +19,7 @@
                         {
                             move_along_path: {
                                 child: {
-                                    move_to: {}
+                                   move_to: {}
                                 }
                             }
                         }

assets/behaviors/pathfinding/staticPathfindingFollow.behavior

@@ -20,7 +20,7 @@
                         {
                             move_along_path: {
                                 child: {
-                                    move_to: {}
+                                   move_to: {}
                                 }
                             }
                         }

assets/behaviors/reliableMoveTo.behavior

@@ -0,0 +1,18 @@
+{
+  loop : {
+      child : {
+        success : {
+          child: {
+            timeout : {
+              "time": 0.7,
+              "child": {
+                lookup: {
+                  tree: "Behaviors:naiveMoveTo"
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+}

assets/prefabs/behaviorNodes/finddummypathtonode.prefab

@@ -0,0 +1,11 @@
+{
+  "BehaviorNode": {
+    "type": "FindDummyPathToNode",
+    "name": "Find Dummy Path",
+    "category": "movement",
+    "shape": "rect",
+    "description": "Finds a dummy path to target consisting of the current and target location",
+    "color": [180, 180, 180, 255],
+    "textColor": [0, 0, 0, 255]
+  }
+}

assets/prefabs/behaviorNodes/findpathtonode.prefab

@@ -0,0 +1,11 @@
+{
+  "BehaviorNode": {
+    "type": "FindPathToNode",
+    "name": "Find Path",
+    "category": "movement",
+    "shape": "rect",
+    "description": "Finds a path to target using FlexiblePathfinding",
+    "color": [180, 180, 180, 255],
+    "textColor": [0, 0, 0, 255]
+  }
+}

assets/prefabs/behaviorNodes/movealongpathnode.prefab

@@ -0,0 +1,11 @@
+{
+  "BehaviorNode": {
+    "type": "MoveAlongPathNode",
+    "name": "Move Along Path",
+    "category": "movement",
+    "shape": "rect",
+    "description": "Move sequentially along this entity's path",
+    "color": [180, 180, 180, 255],
+    "textColor": [0, 0, 0, 255]
+  }
+}

assets/prefabs/behaviorNodes/movetonode.prefab

@@ -0,0 +1,11 @@
+{
+  "BehaviorNode": {
+    "type": "MoveToNode",
+    "name": "Move To",
+    "category": "movement",
+    "shape": "rect",
+    "description": "Move to this entity's immediate move target using the FlexibleMovement mode",
+    "color": [180, 180, 180, 255],
+    "textColor": [0, 0, 0, 255]
+  }
+}

assets/prefabs/behaviorNodes/validatepathnode.prefab

@@ -0,0 +1,11 @@
+{
+  "BehaviorNode": {
+    "type": "ValidatePathNode",
+    "name": "Validate Path",
+    "category": "movement",
+    "shape": "rect",
+    "description": "Validate that this entity can traverse its current path",
+    "color": [180, 180, 180, 255],
+    "textColor": [0, 0, 0, 255]
+  }
+}

assets/prefabs/characters/amphibious.prefab

@@ -0,0 +1,6 @@
+{
+  "parent": "Behaviors:testcharacter",
+  "MinionMove": {
+    "movementTypes": ["walking", "leaping", "swimming"]
+  }
+}

assets/prefabs/characters/flying.prefab

@@ -0,0 +1,6 @@
+{
+  "parent": "Behaviors:testcharacter",
+  "MinionMove": {
+    "movementTypes": ["flying"]
+  }
+}

assets/prefabs/characters/swimming.prefab

@@ -0,0 +1,8 @@
+{
+  "parent": "Behaviors:testcharacter",
+  "MinionMove": {
+    "movementTypes": [
+      "swimming"
+    ]
+  }
+}

assets/prefabs/characters/testcharacter.prefab

@@ -0,0 +1,38 @@
+{
+  "MinionMove": {
+    "movementTypes": ["walking", "leaping"]
+  },
+  "NameTag": { "text": "testcharacter" },
+  "Behavior" : {
+    "tree" : "naiveMoveTo"
+  },
+  "persisted" : true,
+  "location" : {},
+  "Character": {},
+  "CharacterHeldItem" : { },
+  "Network" :{},
+  "Health" : {
+    "maxHealth": 1,
+    "currentHealth": 1,
+    "excessSpeedDamageMultiplier": 0,
+    "destroyEntityOnNoHealth" : true
+  },
+  "Trigger" : {
+    "detectGroups" : ["engine:debris", "engine:sensor"]
+  },
+  "CreatureNameGenerator" : {
+    "genderRatio" : 0.5,
+    "nobility" : 0.5,
+    "theme": "DWARF"
+  },
+  "AliveCharacter": {},
+  "CharacterMovement" : {
+    "groundFriction" : 16,
+    "speedMultiplier" : 0.3,
+    "distanceBetweenFootsteps" : 0.2,
+    "distanceBetweenSwimStrokes" : 2.5,
+    "height" : 0.9,
+    "radius" : 0.3,
+    "jumpSpeed" : 12
+  }
+}

assets/prefabs/items/moveto.prefab

@@ -0,0 +1,12 @@
+{
+  "parent": "engine:iconItem",
+  "DebugMoveTo": {},
+  "DisplayName": {
+    "name": "Path to"
+  },
+  "Item" : {
+    "name" : "Walk to block",
+    "icon" : "engine:items#walkToJob",
+    "usage" : "ON_BLOCK"
+  }
+}

assets/ui/debug.ui

@@ -0,0 +1,4 @@
+{
+  "type": "FlexibleMovementDebugLayout",
+  "skin": "engineDefault"
+}

module.txt

@@ -12,6 +12,10 @@
             "optional": true,
             "because": "tests/ClusterDebugger"
         },
+        {
+            "id": "FlexiblePathfinding",
+            "minVersion": "1.0.0"
+        },
         {
             "id": "Health",
             "minVersion": "2.0.0-SNAPSHOT"
@@ -20,10 +24,6 @@
             "id": "Inventory",
             "minVersion": "1.1.0"
         },
-        {
-            "id": "Pathfinding",
-            "minVersion": "1.0.0"
-        },
         {
             "id": "ModuleTestingEnvironment",
             "minVersion": "0.3.0",