Feature/new http #62
Feature/new http #62
Conversation
…() to be inline with angular
| HttpInterceptorService, | ||
| ], | ||
| }) | ||
| export class CovalentHttpModule { |
There was a problem hiding this comment.
shouldn't this class definition be in it's own file? typically i thought index.ts just described the things being exported from the different services.
| }).catch((error: Response) => { | ||
| return this._errorResolve(error); | ||
| }); | ||
| return this._setupRequest(this._http.delete(url, this._requestResolve(options))); |
There was a problem hiding this comment.
HTTP 1.1 allows for a body in a DELETE call- https://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-19
The most prominent example of this I can think of is elasticsearch passes a body in a DELETE when removing objects.
There was a problem hiding this comment.
Problem is that method Http#delete() in angular doesnt support a body parameter, we are just wrapping that service. Although for those cases, we have the generic request method that allows to set a method DELETE with body.
There was a problem hiding this comment.
Maybe something we take note of and deal with later, esp. since angular doesn't support it.
Description
Update
httpmodule to provide interceptors to be inline on how ngModule works.#58
#65
What's included?
provideInterceptors()method fromhttpmodule.Response/RequestOptionsobjects passed through the pipeline would not be received at the end stage (success/error), even if the pipeline returned a different object.httpmodule.NgModulenotation and provided interceptors withforRoot(). e.g.CovalentHttpModule.forRoot([InterceptorA, InterceptorB])httpdocs.README.mdwith setup.Test Steps
ng serveNote: There is no easy way to test it, since you would have to create a service and interceptors just for the tests and point to a real API. (or mock API)