Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): upgrading storybook to v7 #2064

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

owilliams320
Copy link
Collaborator

Description

Upgrading storybook to latest version v7

What's included?

  • reformatted stories to use CSF (component story format)
  • Styling tweaks to MDX guides from new version of storybook
  • small update to Readme setup reference

Test Steps

  • npm run storybook
  • then wait for storybook to open
  • finally test all the stories to ensure they were working as before

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

@owilliams320 owilliams320 force-pushed the feat/upgrade-storybook branch 5 times, most recently from 47b745c to fc0d298 Compare October 30, 2023 15:55
mikespudwebb
mikespudwebb previously approved these changes Nov 1, 2023
Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owilliams320 owilliams320 merged commit efd2598 into main Nov 1, 2023
4 of 6 checks passed
@owilliams320 owilliams320 deleted the feat/upgrade-storybook branch November 1, 2023 20:33
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants