-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): expansion panel web component #2051
Conversation
@carolineguzylak looks like there is a few lint and build issues. You should be able to run locally using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then looks good
import { customElement, property } from 'lit/decorators.js'; | ||
import styles from './cv-expansion-panel-item.scss?inline'; | ||
import '../icon/icon'; | ||
import '../action-ribbon/action-ribbon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this action ribbon import if its not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@carolineguzylak looks like the pipeline did not pass you should be able run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏎️
🎉 This PR is included in version 7.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Developed expansion panel component using Lit framework - implemented in storybook.
What's included?
Test Steps
npm run storybook
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker