Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add raw code toggle to highlight component and update highlight theme #2044

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

DersJ
Copy link
Contributor

@DersJ DersJ commented Aug 10, 2023

Description

Adding ability to toggle between raw and formatted code in syntax highlight component. Also updating theme with new colors and light mode.

What's included?

  • Added new parameters toggleRawCode and rawToggleLabels to flavored markdown
  • Added new parameters toggleRawButton and rawToggleLabels to highlight component
  • Added light mode theme to highlight component theme

Test Steps

  • npm run start
  • then this
  • finally this

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2023-08-10 at 11 17 32 AM Screenshot 2023-08-10 at 11 17 26 AM

mikespudwebb
mikespudwebb previously approved these changes Aug 10, 2023
@adamnel
Copy link
Collaborator

adamnel commented Aug 10, 2023

Can I get a version of this that has no background color on the buttons and using the appropriate text, icon and border colors for the current theme?
image

}
}
}

Copy link
Contributor Author

@DersJ DersJ Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added button theming. Note that it won't work for demo app dark mode because no dark theme is defined.

Screenshot 2023-08-11 at 11 51 58 AM

@mikespudwebb mikespudwebb self-requested a review August 14, 2023 14:37
Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything obviously wrong. Didn't get a chance to run it.

@owilliams320 owilliams320 merged commit 8bfb682 into main Aug 14, 2023
6 checks passed
@owilliams320 owilliams320 deleted the feat/raw-code-toggle branch August 14, 2023 16:03
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants