Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resize): add native resize capabilities to editor #65

Merged
merged 4 commits into from
Jun 8, 2019

Conversation

emoralesb05
Copy link
Collaborator

instead of using automaticLayout + layout fixes

This to improve performance and allow proper e2e testing since the intervals would get in the way.

Also removed unwanted scrollbars and resize in a single step instead of adjustments every 200ms.

instead of using automaticLayout + layout fixes
Copy link
Contributor

@christianmemije christianmemije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not pass in automaticLayout to the monaco editor and just use this implementation instead.

Copy link
Contributor

@christianmemije christianmemije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

display:block;
display: block;
position: relative;
overflow: hidden;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to remove this.

* automaticLayout?: boolean
* @deprecated in favor of our own resize implementation.
*/
@Input('automaticLayout') automaticLayout: boolean = true;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to add a console.warn for deprecation

@emoralesb05 emoralesb05 merged commit 02fff50 into develop Jun 8, 2019
@emoralesb05 emoralesb05 deleted the feat/resize branch June 8, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants