-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resize): add native resize capabilities to editor #65
Conversation
instead of using automaticLayout + layout fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not pass in automaticLayout to the monaco editor and just use this implementation instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
display:block; | ||
display: block; | ||
position: relative; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to remove this.
* automaticLayout?: boolean | ||
* @deprecated in favor of our own resize implementation. | ||
*/ | ||
@Input('automaticLayout') automaticLayout: boolean = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to add a console.warn for deprecation
instead of using automaticLayout + layout fixes
This to improve performance and allow proper e2e testing since the intervals would get in the way.
Also removed unwanted scrollbars and resize in a single step instead of adjustments every 200ms.