-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spec for create and edit Pool #136
Conversation
specs/create_Edit_pool.adoc
Outdated
* Replicas | ||
* Cluster it belongs | ||
* Journal configration | ||
* OSD's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which api will give the available osd's value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anivargi can you provide input on this?
specs/create_Edit_pool.adoc
Outdated
* Cluster it belongs | ||
* Journal configration | ||
* OSD's | ||
* PG Count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two options are available here.
Either use system generated values or use pg calculator. System generate will be provided by which api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User needs to use PG Calc tool and enter the value. tendrl is not going to provide an auto-calculated value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shtripat so should we show both options in UI or should we remove the system generated one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we are going to have system generated option at all. @julienlim can you confirm?
specs/create_Edit_pool.adoc
Outdated
* OSD's | ||
* PG Count | ||
* Owner | ||
* Quotas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner and quotas do api provide this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quotas values quota_max_object
and quota_max_bytes
need to be provided by end user, if quota enabled is selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shtripat Quotas total value is provided on the UI. So I think need it from the API.
You can see the 128GB written in UI. I am talking about that value. https://redhat.invisionapp.com/share/2T9LPMEEB#/screens/217733677
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloudbehl that 128 GB is not quota value, rather its total size available. Thats not a property of pool. It should be coming for the whole pool based on total size available on OSD to data storage.
@gnehapk @kamleshverma1 @anivargi @nthomas-redhat @shtripat Please review this spec. |
specs/create_Edit_pool.adoc
Outdated
* Cluster it belongs | ||
* Journal configration | ||
* OSD's | ||
* PG Count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User needs to use PG Calc tool and enter the value. tendrl is not going to provide an auto-calculated value.
specs/create_Edit_pool.adoc
Outdated
* OSD's | ||
* PG Count | ||
* Owner | ||
* Quotas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quotas values quota_max_object
and quota_max_bytes
need to be provided by end user, if quota enabled is selected.
* Pool Name | ||
* Replicas | ||
* PG-count | ||
* Quotas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quota parameters you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I mean quota_max_object and quota_max_bytes.
specs/create_Edit_pool.adoc
Outdated
* Create a Form for Creating a new pool. | ||
* Create a new secondary side nav which will have(https://redhat.invisionapp.com/share/2T9LPMEEB#/screens/209774648) | ||
- Basic setting | ||
- Advance Configration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling configuration
specs/create_Edit_pool.adoc
Outdated
- Quotas | ||
* Create a list view For the created pools(https://redhat.invisionapp.com/share/2T9LPMEEB#/screens/217733678) | ||
* Create review page with data list view.(https://redhat.invisionapp.com/share/2T9LPMEEB#/screens/217733679) | ||
* List view should have edit button through which we can edit the flowing item listed above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling following
specs/create_Edit_pool.adoc
Outdated
- If create form matches with UI design | ||
- Next, cancel and Create Buttons are working correctly | ||
- List view is created after the creatin of Pools | ||
- You can edit from the list view by clicking on edit button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember Ju talking about dialog based editing of pools and rbds. @julienlim please confirm.
fee41ba
to
57711d4
Compare
Added spec for create and edit Pool
Added spec for create and edit Pool
No description provided.